[webkit-reviews] review denied: [Bug 37508] [Haiku] Rework FontPlatformData implementation : [Attachment 53283] [Haiku] Reimplementation of FontPlatformData.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 14 07:36:36 PDT 2010
David Levin <levin at chromium.org> has denied Stephan Aßmus
<superstippi at gmx.de>'s request for review:
Bug 37508: [Haiku] Rework FontPlatformData implementation
https://bugs.webkit.org/show_bug.cgi?id=37508
Attachment 53283: [Haiku] Reimplementation of FontPlatformData.
https://bugs.webkit.org/attachment.cgi?id=53283&action=review
------- Additional Comments from David Levin <levin at chromium.org>
Only two minor things to fix up.
> Index: WebCore/platform/graphics/haiku/FontPlatformDataHaiku.cpp
> +static inline bool isEmtpyValue(const float size, const bool bold, const
bool oblique)
typo: isEmtpyValue
> +class FontPlatformData::FontPlatformDataPrivate {
> + FontPlatformDataPrivate(const BFont& font);
No need to include the parameter name "font" since it adds no new information.
More information about the webkit-reviews
mailing list