[webkit-reviews] review denied: [Bug 37442] [PATCH] [Qt] Fix compilation with system tray disabled. : [Attachment 53160] Fix style error
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 13 23:32:36 PDT 2010
Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Ismail "cartman" Donmez
<ismail at namtrac.org>'s request for review:
Bug 37442: [PATCH] [Qt] Fix compilation with system tray disabled.
https://bugs.webkit.org/show_bug.cgi?id=37442
Attachment 53160: Fix style error
https://bugs.webkit.org/attachment.cgi?id=53160&action=review
------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
I agree with Simon's proposal, I'd like to give an r- this time. I similar
mechanism exists to disable certain WebKit features if sqlite is not available.
Would the following work ..
contains(DEFINES, QT_NO_SYSTEMTRAYICON):DEFINES += ENABLE_NOTIFICATIONS=0
More information about the webkit-reviews
mailing list