[webkit-reviews] review granted: [Bug 37525] Make failure-reason more forgiving : [Attachment 53286] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 37525: Make failure-reason more forgiving
https://bugs.webkit.org/show_bug.cgi?id=37525

Attachment 53286: Patch
https://bugs.webkit.org/attachment.cgi?id=53286&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	       # FIXME: This could be made more user friendly.
> +	       print "Failed to load layout test results start revision r%s,
can't continue." % start_revision

I think this would be a little clearer like this: "Failed to load layout test
results; can't continue. (start revision = r%s)"

> @@ -237,8 +243,10 @@ class FailureReason(AbstractDeclarativeCommand):
>	       results_to_explain -= fixed_results
>	   if results_to_explain:
>	       print "Failed to explain failures: %s" % results_to_explain
> +	       return 1
>	   else:
>	       print "Explained all results for %s" % builder.name()
> +	       return 0

Our C++ style is not to use "else" after "return".

r=me