[webkit-reviews] review requested: [Bug 28272] WINCE PORT: graphics files only for WINCE : [Attachment 53310] 1) SharedBitmap

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 13 21:31:35 PDT 2010


Kwang Yul Seo <kwangyul.seo at gmail.com> has asked  for review:
Bug 28272: WINCE PORT: graphics files only for WINCE
https://bugs.webkit.org/show_bug.cgi?id=28272

Attachment 53310: 1) SharedBitmap
https://bugs.webkit.org/attachment.cgi?id=53310&action=review

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
Change g_drawPattern and g_drawImage to s_drawPattern and s_drawImage
respectively.
Change g_dcProvider to s_dcProvider ane make it static as it is not used
elsewhere.
Change g_bitmapMap to bitmapMap function as static initializers are forbidden.
Use AffineTransform instead of TransformationMatrix.
Change methods names which start with underscore: _clear -> clearInternal, _set
-> setInternal.
Remove explicit keyword from SharedBitmap constructors as they take multiple
arguments.
Indent initializer list properly.
Use C++ style casts.
Fix other miscellaneous style errors.


More information about the webkit-reviews mailing list