[webkit-reviews] review granted: [Bug 37126] REGRESSION (r56223): http://www.playerpress.com/ shows up twice in the back/forward list. : [Attachment 53291] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 13 16:04:26 PDT 2010


Brady Eidson <beidson at apple.com> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 37126: REGRESSION (r56223): http://www.playerpress.com/ shows up twice in
the back/forward list.
https://bugs.webkit.org/show_bug.cgi?id=37126

Attachment 53291: v1 patch
https://bugs.webkit.org/attachment.cgi?id=53291&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
At this point the variable name "m_quickRedirectComing" is silly  :)

Do you see us adding more logic to currentItemShouldBeReplaced() in the future?
 The name slightly bothers me because it doesn't obviously match the conditions
being tested.

Are we sure we shouldn't adopt this new behavior in the (problematic but still
quite real) cases where we have no m_currentItem?

r+ with a good answer to the m_currentItem question.


More information about the webkit-reviews mailing list