[webkit-reviews] review denied: [Bug 34683] [Haiku] Implement Path, Gradient and flesh out GraphicsContextHaiku : [Attachment 49527] Implement native Path backend.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Stephan Aßmus
<superstippi at gmx.de>'s request for review:
Bug 34683: [Haiku] Implement Path, Gradient and flesh out GraphicsContextHaiku
https://bugs.webkit.org/show_bug.cgi?id=34683

Attachment 49527: Implement native Path backend.
https://bugs.webkit.org/attachment.cgi?id=49527&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few minor nits. Sorry (I would r+ if you could land it).

> Index: WebCore/ChangeLog
> +	       Fixed memory corruption, curtesy of Michael Lotz. We can't just
assign pointers!

courtesy 

> +	   (WebCore::Path::addQuadCurveTo):
> +	       Implemented (curtesy of Michael Lotz).

courtesy 


> Index: WebCore/platform/graphics/haiku/PathHaiku.cpp
> +// A one pixel sized BBitmap for drawing into. Default high-color of BViews

Single space after . in comments.


> +	   virtual status_t IterateLineTo(int32 lineCount, BPoint* linePts)

Abbreviations are discouraged in WebKit. "Pts".

> +    // BShapeIterator allows us to modify the path data "in place"

Please add a "."