[webkit-reviews] review denied: [Bug 37498] Web Inspector: in Profiles panel, search always displays "Not found", although it jumps through the results : [Attachment 53246] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 13 07:25:17 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 37498: Web Inspector: in Profiles panel, search always displays "Not
found", although it jumps through the results
https://bugs.webkit.org/show_bug.cgi?id=37498

Attachment 53246: proposed patch
https://bugs.webkit.org/attachment.cgi?id=53246&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +	   // The profile passed in the constructor contains important
properties, but
> +	   // no actual data. To have both properties and data, we chain the
profile
> +	   // we've got from 'getProfile' with the one passed in the
constructor.
> +	   profile.__proto__ = self.profile;

Assigning proto is nothing but the hack. What you should do is to create an
object with properties around the payload you've received just as it is done in
case of DOMAgent.js.


More information about the webkit-reviews mailing list