[webkit-reviews] review denied: [Bug 37385] [Haiku] Use all the new system cursors in CursorHaiku.cpp : [Attachment 53097] [Haiku] Use all the new system cursors

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Stephan Aßmus
<superstippi at gmx.de>'s request for review:
Bug 37385: [Haiku] Use all the new system cursors in CursorHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=37385

Attachment 53097: [Haiku] Use all the new system cursors
https://bugs.webkit.org/attachment.cgi?id=53097&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog
> +2010-04-11  Stephan Aßmus  <superstippi at gmx.de>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Haiku] Use all the new system cursors available in recent Haiku
revisions.
> +	   <https://bugs.webkit.org/show_bug.cgi?id=37385>
> +
> +	   Covered by existing tests.
> +
> +	   * platform/Cursor.h:
> +	       - Added necessary include.
> +	       - Changed definitions of PlatformCursor and
PlatformCursorHandle.

It is clear that you did this but why you did it is unclear. This results in an
ifdef in Cursor.h (to change the return type of impl()) where all other ports
have been able to avoid it.

r- due to new ifdef which changes the return type of impl().