[webkit-reviews] review granted: [Bug 37218] Implement FileStreamProxy that calls FileStream methods on FileThread for FileAPI : [Attachment 53209] Fixed the mess in diff

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has granted Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 37218: Implement FileStreamProxy that calls FileStream methods on
FileThread for FileAPI
https://bugs.webkit.org/show_bug.cgi?id=37218

Attachment 53209: Fixed the mess in diff
https://bugs.webkit.org/attachment.cgi?id=53209&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
r=me

Please fix several minor issues before landing. Thanks.

> diff --git a/WebCore/html/FileStreamProxy.cpp
b/WebCore/html/FileStreamProxy.cpp
> +FileStreamProxy::FileStreamProxy(ScriptExecutionContext* context,
FileStreamClient* client)
> +    : m_context(context)
> +    , m_client(client)
> +    , m_stream(FileStream::create(this))
> +{
> +    // Holds an extra ref so that the instance will not get deleted while
there can be any tasks on the file thread.
> +    ref();
Please add an empty line here for better readability.

> +void FileStreamProxy::stop()
> +{
> +    // Clear the client so that we won't be calling callbacks on the client.

> +    m_client = 0;
Please add an empty line here for better readability.

> diff --git a/WebCore/html/FileStreamProxy.h b/WebCore/html/FileStreamProxy.h
> +    FileThread* fileThread();
Please add an empty line here.

> +    bool m_running;
Please remove this leftover.