[webkit-reviews] review denied: [Bug 37480] Add query string tests from Google URL : [Attachment 53214] Layout Test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 12 20:23:15 PDT 2010
Adam Barth <abarth at webkit.org> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 37480: Add query string tests from Google URL
https://bugs.webkit.org/show_bug.cgi?id=37480
Attachment 53214: Layout Test
https://bugs.webkit.org/attachment.cgi?id=53214&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
+<script src="resources/utilities.js"></script>
I don't think we can edit these files because they are generated from the
make-test-wrappers script.
+ ["as#df", "as%23df"],
I don't think this result is correct, but I agree that we should just literally
land what's in the unit tests. We can do a separate pass to understand the
different behaviors here.
Review- because we can't change the generated files. I think it's ok to
copy/paste that small function between tests.
More information about the webkit-reviews
mailing list