[webkit-reviews] review granted: [Bug 37473] WebKit should have more robust last-chance font fallback on Windows : [Attachment 53199] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 12 17:00:12 PDT 2010
mitz at webkit.org has granted Steve Falkenburg <sfalken at apple.com>'s request for
review:
Bug 37473: WebKit should have more robust last-chance font fallback on Windows
https://bugs.webkit.org/show_bug.cgi?id=37473
Attachment 53199: Patch
https://bugs.webkit.org/attachment.cgi?id=53199&action=review
------- Additional Comments from mitz at webkit.org
> +#if PLATFORM(WIN)
> + SimpleFontData* FontCache::fontDataFromDescriptionAndLogFont(const
FontDescription&, const LOGFONT&);
> +#endif
I’d avoid this method and replace it with a file-static function that takes a
FontCache*, but r=me either way.
More information about the webkit-reviews
mailing list