[webkit-reviews] review granted: [Bug 36623] Relative URLs don't work for notifications in Chromium : [Attachment 53029] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 12 11:16:39 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted Aaron Boodman
<aa at chromium.org>'s request for review:
Bug 36623: Relative URLs don't work for notifications in Chromium
https://bugs.webkit.org/show_bug.cgi?id=36623

Attachment 53029: Patch
https://bugs.webkit.org/attachment.cgi?id=53029&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 6f8e025..72aa8d5 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,13 @@
> +2010-04-09  Aaron Boodman  <aa at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Support relative URLs for notifiications on Chromium.
> +	   https://bugs.webkit.org/show_bug.cgi?id=36623

Please add a few more details of exactly what you're doing here.


All comments seem to have been addressed.  Looks fine to me.  And the domain
expert on this did an informal review.	r=me


More information about the webkit-reviews mailing list