[webkit-reviews] review requested: [Bug 36883] [Qt] Parallel painting in WebKit : [Attachment 53162] fourth patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 12 07:02:12 PDT 2010


Zoltan Herczeg <zherczeg at webkit.org> has asked	for review:
Bug 36883: [Qt] Parallel painting in WebKit
https://bugs.webkit.org/show_bug.cgi?id=36883

Attachment 53162: fourth patch
https://bugs.webkit.org/attachment.cgi?id=53162&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
Phew, this patch has been grown to quite big! (120k now) Now it covers most of
the GraphicsContext, and works well with the majority of the pages, even with
svg drawings. I put an r? to get some feedback from the reviewers, not because
it is a finished patch.

My current blocker is the RenderTheme: it turned out not only the
GraphicsContext draws to the screen. Unfortunately the RenderTheme object is
far more platform dependent than GraphicsContext. QPicture might be a useful
workaround here, but it will be Qt specific. The RenderFrame base class is
heavily dependent from RenderObject, RenderStyle and Element pointers, and
would not worth to clone them for a thread. I don't see any platform
independent solution here :( I would appreciate any suggestion!


More information about the webkit-reviews mailing list