[webkit-reviews] review requested: [Bug 23556] On RTL pages, horizontal scrollbar is missing : [Attachment 53150] A proposed fix 5

Sun Apr 11 23:05:47 PDT 2010

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 23556: On RTL pages, horizontal scrollbar is missing
https://bugs.webkit.org/show_bug.cgi?id=23556

Attachment 53150: A proposed fix 5
https://bugs.webkit.org/attachment.cgi?id=53150&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Sorry for my slow update.
I have updated my change to change the RenderView class instead of changing the
RenderBlock class as suggested by mitz at webkit.org. (This change also changes
the RenderBox class not only to synchronize the text direction of a RenderView
object with the one of a <body> element, but also to paint the background of a
RenderView object with the color of the <body> element.) Unfortunately, this
change uses a pixel test because I haven't find any good ideas to write a text
test for this bug. Would it be possible to review the updated change and give
me your comments?

Regards,

Hironori Bono