[webkit-reviews] review requested: [Bug 37112] aria-liveregion-notifications.html fails on leopard release bot : [Attachment 53032] patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 37112: aria-liveregion-notifications.html fails on leopard release bot
https://bugs.webkit.org/show_bug.cgi?id=37112

Attachment 53032: patch
https://bugs.webkit.org/attachment.cgi?id=53032&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
this change addresses comments eric made.

Two issues he raised
1) How are the ivars memory managed in AccessibilityUIElement.h. 
    m_platformElement is assigned/retained/released in platform specific code.
That has always been that way.
    I'm adding (for mac only, unless others need it), an "id
m_notificationHandler". This will also be assigned/retained/released by the
platform
    specific implementation. 

2) Will AXUIElements be released when the page exits? The answer to that seems
no, which is the reason for this bug. It seems bleed over was causing
the flakiness before. My changes address this by requiring layout test writers
(on the mac) to add and remove notification listeners within the test. If the
notification listen is not removed, then DRT will assert. Forcing adding and
removal
ensures that we don't get bleed over of notifications at least.