[webkit-reviews] review canceled: [Bug 37060] List item markers are not always updated after changes in the DOM : [Attachment 52910] 2nd changeset

[bugzilla-daemon at webkit.org]

Jakub Wieczorek <jwieczorek at webkit.org> has canceled Jakub Wieczorek
<jwieczorek at webkit.org>'s request for review:
Bug 37060: List item markers are not always updated after changes in the DOM
https://bugs.webkit.org/show_bug.cgi?id=37060

Attachment 52910: 2nd changeset
https://bugs.webkit.org/attachment.cgi?id=52910&action=review

------- Additional Comments from Jakub Wieczorek <jwieczorek at webkit.org>
(In reply to comment #36)
> My take on this is that I think it will be safe, and in fact is an
improvement
> in making things logical, but we should think about the likely edge cases and

> make tests.

OK, sounds good to me.

I am posting the patch now but I'm going to see if we can include some tests
with this change. The existing test coverage seems to be pretty good but there
might be some edge cases that I could have missed and that the existing tests
also don't cover. However, it seems that we will need to get the DRT support
from the 1st patch first landed if we want to include any plain text tests.
We could also make this single change without adding new tests and let them
come with the other patch. I'm fine with either of the options.