[webkit-reviews] review denied: [Bug 36783] Update of fixed elements is not made correctly when the page has been scrolled : [Attachment 52970] Patch with updatePositions()

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin.poulain at nokia.com> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 36783: Update of fixed elements is not made correctly when the page has
been scrolled
https://bugs.webkit.org/show_bug.cgi?id=36783

Attachment 52970: Patch with updatePositions()
https://bugs.webkit.org/attachment.cgi?id=52970&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
(In reply to comment #11)
> (From update of attachment 52970 [details])
> This patch was attached with the wrong mime type and missing the "patch"
flag. 
> You should consider using one of our patch attaching tools like "webkit-patch

> upload" for uploading your patches, as they take care of all these details
for
> you.
> 
> See "WebKitTools/Scripts/webkit-patch help" for more information.

Sorry, I was in a hurry. I will have a look at webkit-patch, thanks for the
info.


> (From update of attachment 52970 [details])
> I'm not seeing the RenderLayer.cpp changes in this patch.

Damn, I forgot to add the change to the commit. I will try to update it this
weekend.