[webkit-reviews] review granted: [Bug 37194] Prevent wrong use of PrintContext : [Attachment 52716] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 9 14:04:01 PDT 2010


Eric Seidel <eric at webkit.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 37194: Prevent wrong use of PrintContext
https://bugs.webkit.org/show_bug.cgi?id=37194

Attachment 52716: Patch v2
https://bugs.webkit.org/attachment.cgi?id=52716&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You should consider documenting what m_isPrinting is for in teh header,
otherwise this looks OK (- the release-only auto-end stuff).

r=me with the two above comments addressed.


More information about the webkit-reviews mailing list