[webkit-reviews] review denied: [Bug 37204] RenderThemeChromiumMac.mm should share code with RenderThemeMac.mm : [Attachment 52732] patch v0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 9 14:01:09 PDT 2010


Eric Seidel <eric at webkit.org> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 37204: RenderThemeChromiumMac.mm should share code with RenderThemeMac.mm
https://bugs.webkit.org/show_bug.cgi?id=37204

Attachment 52732: patch v0
https://bugs.webkit.org/attachment.cgi?id=52732&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This guard seems unecessary:
60 #if PLATFORM(CHROMIUM)
15961 PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page*)
16062 {
I'm ready to r+ this with additional comments in the header explaining the new
methods.


More information about the webkit-reviews mailing list