[webkit-reviews] review granted: [Bug 37353] [RenderStyle Cleanup] Clean up CursorData, CursorList : [Attachment 52986] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 9 13:40:15 PDT 2010
Adam Roben (aroben) <aroben at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 37353: [RenderStyle Cleanup] Clean up CursorData, CursorList
https://bugs.webkit.org/show_bug.cgi?id=37353
Attachment 52986: Patch
https://bugs.webkit.org/attachment.cgi?id=52986&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> void RenderStyle::addCursor(CachedImage* image, const IntPoint& hotSpot)
> {
> - CursorData data;
> - data.cursorImage = image;
> - data.hotSpot = hotSpot;
> + CursorData data(image, hotSpot);
> if (!inherited.access()->cursorData)
> inherited.access()->cursorData = CursorList::create();
> inherited.access()->cursorData->append(data);
I don't think you need a local variable here at all.
r=me
More information about the webkit-reviews
mailing list