[webkit-reviews] review granted: [Bug 34930] Implement interactive validation for forms : [Attachment 52966] Proposed patch (rev.9)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 9 10:41:25 PDT 2010


Darin Adler <darin at apple.com> has granted TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 34930: Implement interactive validation for forms
https://bugs.webkit.org/show_bug.cgi?id=34930

Attachment 52966: Proposed patch (rev.9)
https://bugs.webkit.org/attachment.cgi?id=52966&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +static inline HTMLFormControlElement* submitElementFrom(const Event* event)

I'd call it submitElementFromEvent instead of leaving the proposition hanging
here.

> +    // Copy formElments because event handlers called from

Typo: formElments.


More information about the webkit-reviews mailing list