[webkit-reviews] review denied: [Bug 37236] Cannot resubmit form after submission fails : [Attachment 52794] suggested patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 9 09:44:03 PDT 2010


Darin Adler <darin at apple.com> has denied Joe Mason <jmason at rim.com>'s request
for review:
Bug 37236: Cannot resubmit form after submission fails
https://bugs.webkit.org/show_bug.cgi?id=37236

Attachment 52794: suggested patch
https://bugs.webkit.org/attachment.cgi?id=52794&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Bug fixes require a test case. If you can't make an automated test case please
include a manual one. But I think you can make an automated test case using
http.

And I'm not sure it's safe to just clear multiple submission protection for
failures that don't match the form URL. It might require more study of the
patches that introduced this mechanism and some further thought about how a
load of a different main resource might come through.


More information about the webkit-reviews mailing list