[webkit-reviews] review granted: [Bug 36454] [GTK] Improve reporting of frame loader callbacks in DRT : [Attachment 52947] Print didStartProvisionalLoadForFrame in the callback of load-committed signal
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 9 05:43:45 PDT 2010
Gustavo Noronha (kov) <gns at gnome.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 36454: [GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454
Attachment 52947: Print didStartProvisionalLoadForFrame in the callback of
load-committed signal
https://bugs.webkit.org/attachment.cgi?id=52947&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
849 if (gLayoutTestController->dumpFrameLoadCallbacks()) {
850 if (loadStatus == WEBKIT_LOAD_PROVISIONAL) {
Doing early returns here would be more usual. I hope you have run all the tests
with this change in? =)
More information about the webkit-reviews
mailing list