[webkit-reviews] review denied: [Bug 31732] Web Inspector: Cannot select elements within iframes with the magnifying glass. : [Attachment 52945] [PATCH] Proposed fix.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 9 04:22:40 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 31732: Web Inspector: Cannot select elements within iframes with the
magnifying glass.
https://bugs.webkit.org/show_bug.cgi?id=31732
Attachment 52945: [PATCH] Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=52945&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
> void InspectorController::inspect(Node* node)
> {
> - if (!canPassNodeToJavaScript(node) || !enabled())
> - return;
> -
If (!enabled) check should be preserved. r- for that
Would be really nice if we started accompanying Web Inspector changes with
tests.
More information about the webkit-reviews
mailing list