[webkit-reviews] review denied: [Bug 36899] Make DumpRenderTree parallelizable : [Attachment 52726] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 8 23:31:48 PDT 2010


Eric Seidel <eric at webkit.org> has denied Csaba Osztrogonac <ossy at webkit.org>'s
request for review:
Bug 36899: Make DumpRenderTree parallelizable
https://bugs.webkit.org/show_bug.cgi?id=36899

Attachment 52726: updated patch
https://bugs.webkit.org/attachment.cgi?id=52726&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Stylistically this is wrong.  variable names are wrong, spacing is wrong.  You
changed only one caller of getenv.

This is an incomplete hack.  It's a step in the right direction, but not a full
fix.


More information about the webkit-reviews mailing list