[webkit-reviews] review requested: [Bug 37303] Application crash on exit if NPPlugin is loaded : [Attachment 52932] Alternative patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 8 19:38:23 PDT 2010
David Leong <david.leong at nokia.com> has asked for review:
Bug 37303: Application crash on exit if NPPlugin is loaded
https://bugs.webkit.org/show_bug.cgi?id=37303
Attachment 52932: Alternative patch
https://bugs.webkit.org/attachment.cgi?id=52932&action=review
------- Additional Comments from David Leong <david.leong at nokia.com>
The plugin view in symbian can only be of a type PluginContainerSymbian. The
proxy object is initialized to NULL or a QGraphicsProxyWidget*. There is no
harm deleting NULLs, so there is no need to do the qobject_cast. If the
platform widget pointer is not null, it should be safe to delete both the proxy
and the widget itself.
More information about the webkit-reviews
mailing list