[webkit-reviews] review requested: [Bug 37303] Application crash on exit if NPPlugin is loaded : [Attachment 52930] fix to check for null pointer

[bugzilla-daemon at webkit.org]

David Leong <david.leong at nokia.com> has asked  for review:
Bug 37303: Application crash on exit if NPPlugin is loaded
https://bugs.webkit.org/show_bug.cgi?id=37303

Attachment 52930: fix to check for null pointer
https://bugs.webkit.org/attachment.cgi?id=52930&action=review

------- Additional Comments from David Leong <david.leong at nokia.com>
Qt-Symbian applications which use Qtwebkit and load Netscape plugins currently
crashes on exit.

The crash has been narrowed down to:

void PluginView::platformDestroy()
{
    QWebPageClient* client =
m_parentFrame->view()->hostWindow()->platformPageClient();
    if (qobject_cast<QGraphicsWebView*>(client->pluginParent()))   // Crashes
here
	delete
static_cast<PluginContainerSymbian*>(platformPluginWidget())->proxy();
    else
	delete platformPluginWidget();
}

The crash is caused by a NULL client*. qobject_cast causes an exception as it
requires a valid QObject pointer to access underlying Qtmetadata.