[webkit-reviews] review requested: [Bug 37060] List item markers are not always updated after changes in the DOM : [Attachment 52910] 2nd changeset

[bugzilla-daemon at webkit.org]

Jakub Wieczorek <jwieczorek at webkit.org> has asked  for review:
Bug 37060: List item markers are not always updated after changes in the DOM
https://bugs.webkit.org/show_bug.cgi?id=37060

Attachment 52910: 2nd changeset
https://bugs.webkit.org/attachment.cgi?id=52910&action=review

------- Additional Comments from Jakub Wieczorek <jwieczorek at webkit.org>
> You say it "does really affect the current code". I find that surprising
since
> the DOM tree and render tree don't always have identical hierarchies, but
maybe
> I'm wrong about that. 

You're right here. This could be a dangerous change to make. I'm not sure if it
would work correctly with e.g. the list object living in a different layer than
an item. That's only a guess as I haven't tested that. I think we can make a
safer and a simpler change that will address the issue.

Posting the proposed change here in a separate patch as you suggested. I should
have filed another bug for it probably but I'm not sure if it's not better to
incorporate it to the first one if it's an one-liner (with no tests and a
comment that is not true until the main patch gets in).

I'm planning on doing the proper testing tomorrow to see if it's the right to
do.