[webkit-reviews] review requested: [Bug 37053] WorkerGlobalScope.close() should let the currently running script complete execution, then terminate the worker. : [Attachment 52909] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 8 15:58:28 PDT 2010
Dmitry Titov <dimich at chromium.org> has asked for review:
Bug 37053: WorkerGlobalScope.close() should let the currently running script
complete execution, then terminate the worker.
https://bugs.webkit.org/show_bug.cgi?id=37053
Attachment 52909: Patch.
https://bugs.webkit.org/attachment.cgi?id=52909&action=review
------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Updated patch:
- fixed comments and typos.
- Added a check into WorkerScriptController for JCS to mimic what v8 version
also does to prevent re-entry into JS when further execution is forbidden.
- Added 2 new tests, one that Andrew Wilson has suggested and another one for
MessagePort events dispatching while calling close().
More information about the webkit-reviews
mailing list