[webkit-reviews] review granted: [Bug 37286] Testing utility for CodeGeneratorV8.pm : [Attachment 52882] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 8 13:35:09 PDT 2010


Nate Chapin <japhet at chromium.org> has granted Yaar Schnitman
<yaar at chromium.org>'s request for review:
Bug 37286: Testing utility for CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=37286

Attachment 52882: Patch
https://bugs.webkit.org/attachment.cgi?id=52882&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
If you could open a bug for getting the output of CodeGeneratorV8.pm more style
compliant, that would be great (or we could attach it to this bug I suppose).

> diff --git a/WebCore/bindings/v8/test/TestObj.idl
b/WebCore/bindings/v8/test/TestObj.idl
> new file mode 100644
> index 0000000..628b618
> --- /dev/null
> +++ b/WebCore/bindings/v8/test/TestObj.idl
> @@ -0,0 +1,65 @@
> +/*
> + * Copyright (C) 2009 Google Inc. All rights reserved.

2010 :)


More information about the webkit-reviews mailing list