[webkit-reviews] review granted: [Bug 37271] [chromium] Expose SecurityOrigin::canRequest in WebSecurityOrigin. : [Attachment 52864] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 8 11:00:33 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted
jochen at chromium.org's request for review:
Bug 37271: [chromium] Expose SecurityOrigin::canRequest in WebSecurityOrigin.
https://bugs.webkit.org/show_bug.cgi?id=37271

Attachment 52864: Patch
https://bugs.webkit.org/attachment.cgi?id=52864&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +    // Returns true if this WebSecurityOrigin can read content retrieved
from
> +    // the given URL. For example, call this function before issuing
> +    // XMLHttpRequests.
> +    WEBKIT_API bool canRequest(const WebURL&) const;

nit: The XMLHttpRequest example doesn't really apply to WebKit API consumers.

Otherwise, this change is fine.  Please post a revised patch for the commit
queue.


More information about the webkit-reviews mailing list