[webkit-reviews] review granted: [Bug 31482] Refactor DatabaseTracker.h and eliminate all #ifdefs : [Attachment 52454] patch #1: remove the dependency on OriginQuotaManager from DatabaseTracker.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 8 08:42:35 PDT 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 31482: Refactor DatabaseTracker.h and eliminate all #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=31482

Attachment 52454: patch #1: remove the dependency on OriginQuotaManager from
DatabaseTracker.h
https://bugs.webkit.org/attachment.cgi?id=52454&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me, except: 

>  
>  DatabaseTracker& DatabaseTracker::tracker()
>  {
> @@ -74,6 +63,16 @@ DatabaseTracker::DatabaseTracker()
>      : m_client(0)
>  {
>      SQLiteFileSystem::registerSQLiteVFS();
> +
> +    quotaManager = new OriginQuotaManager();

I think you should just do DEFINE_STATIC_LOCAL accessor, like you had in the
previous patch. Tracker's lifetime is the same (it's also STATIC_LOCAL), so
there's no need for trying to control its lifetime.


More information about the webkit-reviews mailing list