[webkit-reviews] review denied: [Bug 36454] [GTK] Improve reporting of frame loader callbacks in DRT : [Attachment 51909] Print didStartProvisionalLoadForFram in the callback of signal::load-committed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 8 06:24:07 PDT 2010


Gustavo Noronha (kov) <gns at gnome.org> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 36454: [GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

Attachment 51909: Print didStartProvisionalLoadForFram in the callback of
signal::load-committed
https://bugs.webkit.org/attachment.cgi?id=51909&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 849	 if (gLayoutTestController->dumpDatabaseCallbacks()) {

This is wrong, given we are talking about frame loader, not about databases
here. And you should also unskip the tests that had to be skipped because of
missing this functionality.


More information about the webkit-reviews mailing list