[webkit-reviews] review granted: [Bug 37251] Rename target to configuration in new-run-webkit-tests to match the rest of WebKit : [Attachment 52843] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 8 00:27:31 PDT 2010
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 37251: Rename target to configuration in new-run-webkit-tests to match the
rest of WebKit
https://bugs.webkit.org/show_bug.cgi?id=37251
Attachment 52843: Patch
https://bugs.webkit.org/attachment.cgi?id=52843&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Wow, some of this code hurts.
+ optparser.add_option('--release', action='store_const', const='Release',
+ dest="configuration", help='Set the configuration to
Debug')
should say Release. otherwise r=me.
More information about the webkit-reviews
mailing list