[webkit-reviews] review granted: [Bug 37186] [Chromium] Register Chromium's SQLite VFS even when running in single-process mode : [Attachment 52809] patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 37186: [Chromium] Register Chromium's SQLite VFS even when running in
single-process mode
https://bugs.webkit.org/show_bug.cgi?id=37186

Attachment 52809: patch
https://bugs.webkit.org/attachment.cgi?id=52809&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 57235)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,35 @@
> +2010-04-07  Dumitru Daniliuc  <dumi at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Fix Chromium's HTML5 DB support in --single-process mode.
> +

No newline here.

> +	   https://bugs.webkit.org/show_bug.cgi?id=37186.
> +
> +	   Always register and use Chromium's SQLite VFS for
> +	   WebSQLDatabases. Keep using the default VFS in all other
> +	   cases. This change should allow Chromium to support
> +	   WebSQLDatabases in --single-process mode.
> +
> +	   Also, cleaning up a big SQLiteFileSystemChromium and getting rid

This sentence doesn't parse in my head.....a big what?


r=me, provided Michael signs off on it as well and you double check that
LocalStorage still works under --single-process.