[webkit-reviews] review denied: [Bug 37186] [Chromium] Register Chromium's SQLite VFS even when running in single-process mode : [Attachment 52795] patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 37186: [Chromium] Register Chromium's SQLite VFS even when running in
single-process mode
https://bugs.webkit.org/show_bug.cgi?id=37186

Attachment 52795: patch
https://bugs.webkit.org/attachment.cgi?id=52795&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 57235)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,29 @@
> +2010-04-07  Dumitru Daniliuc  <dumi at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Always register and use Chromium's SQLite VFS for
> +	   WebSQLDatabases. Keep using the default VFS in all other
> +	   cases. This change should allow Chromium to support
> +	   WebSQLDatabases in --single-process mode.
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=37186.

Please follow the standard format for change logs.

Title
url

description

Also, please describe the "full mutex" part of the change.


> Index: WebCore/platform/sql/SQLiteFileSystem.h
> ===================================================================
> --- WebCore/platform/sql/SQLiteFileSystem.h	(revision 57230)
> +++ WebCore/platform/sql/SQLiteFileSystem.h	(working copy)
> @@ -52,7 +52,8 @@ public:
>      // fileName - The name of the database file.
>      // database - The SQLite structure that represents the database stored
>      //	     in the given file.
> -    static int openDatabase(const String& fileName, sqlite3** database);
> +    // forWebSQLDatabase - True, if and only if we're opening a Web SQL
Database file.

Probably you should explain why this is necessary.  (Chromium needs this info.)