[webkit-reviews] review requested: [Bug 37236] Cannot resubmit form after submission fails : [Attachment 52794] suggested patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 7 15:43:38 PDT 2010


Joe Mason <jmason at rim.com> has asked  for review:
Bug 37236: Cannot resubmit form after submission fails
https://bugs.webkit.org/show_bug.cgi?id=37236

Attachment 52794: suggested patch
https://bugs.webkit.org/attachment.cgi?id=52794&action=review

------- Additional Comments from Joe Mason <jmason at rim.com>
This patch will fix the problem.  It seems to me that if an error is received,
always clearing m_submittedFormURL should be safe.  Under what circumstances
would it NOT match the original URL for a FrameLoader?

If this is too invasive, an alternative is to compare only the base URL's but
not the query parts.

I'll gladly add a layout test if someone can help me figure out how.


More information about the webkit-reviews mailing list