[webkit-reviews] review denied: [Bug 37228] Allow white listing access from origin to local origin : [Attachment 52780] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 37228: Allow white listing access from origin to local origin
https://bugs.webkit.org/show_bug.cgi?id=37228

Attachment 52780: Patch
https://bugs.webkit.org/attachment.cgi?id=52780&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ bool isAccessWhiteListed(const SecurityOrigin& targetOrigin) const;

We should be passing around SecurityOrigin as a SecurityOrigin* not a const
SecurityOrigin& because its a pointer type, not a reference type.

What was the resolution on

+var localImageLocation =
layoutTestController.pathToLocalResource('file:///tmp/LayoutTests/http/tests/se
curity/resources/compass.jpg');

?

+	 PassRefPtr<SecurityOrigin> targetOrigin = SecurityOrigin::create(url);


This should be a RefPtr.  PassRefPtr is only for parameter.  You might find it
useful to read this documentation:

http://webkit.org/coding/RefPtr.html

Other than that, this patch is looking good.