[webkit-reviews] review denied: [Bug 37215] Web Inspector: be more explicit about resource loading errors : [Attachment 52769] Log error message to inspector console if a resource fails to load. Disable checking of mime-type consistency for failed resource (fixed messages)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 7 12:57:56 PDT 2010
Timothy Hatcher <timothy at hatcher.name> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 37215: Web Inspector: be more explicit about resource loading errors
https://bugs.webkit.org/show_bug.cgi?id=37215
Attachment 52769: Log error message to inspector console if a resource fails to
load. Disable checking of mime-type consistency for failed resource (fixed
messages)
https://bugs.webkit.org/attachment.cgi?id=52769&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> + // Safari doesn't report resource URL, so do our best by retrieving it
from our
> + // resource record (obviously, works only with resource tracking
enabled).
It isn't Safari at this level. It would be CFNetwork. I am surprised the URL
isn't there, since we do show errors in Safari's activity monitor just fine and
it uses a similar code path as the Inspector's didFailLoading.
Otherwise r+.
More information about the webkit-reviews
mailing list