[webkit-reviews] review denied: [Bug 37141] [Chromium] Crasher in popup menu code : [Attachment 52692] Adding a layout test

Wed Apr 7 11:10:14 PDT 2010

Jian Li <jianli at chromium.org> has denied Jay Campan <jcampan at google.com>'s
request for review:
Bug 37141: [Chromium] Crasher in popup menu code
https://bugs.webkit.org/show_bug.cgi?id=37141

Attachment 52692: Adding a layout test
https://bugs.webkit.org/attachment.cgi?id=52692&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
The bug title should be prefixed with "[Chromium]" to indicate that this is for
chromium only.

> --- LayoutTests/ChangeLog	(revision 57181)
> +++ LayoutTests/ChangeLog	(working copy)
> @@ -1,3 +1,14 @@
> +ï»¿2010-04-06  Jay Civelli  <jcivelli at chromium.org>
Garbage characters at the beginning.

> --- LayoutTests/platform/chromium/fast/forms/search-popup-crasher.html       
(revision 0)
> +++ LayoutTests/platform/chromium/fast/forms/search-popup-crasher.html       
(revision 0)
> @@ -0,0 +1,27 @@
> +<HTML>
> +<HEAD>
> +<script>
> +window.onload = function()
> +{
> +    if (window.layoutTestController)
> +	   layoutTestController.dumpAsText();
> +
> +
Please remove the extra empty line.

> +    if (window.location.href.indexOf('formSubmitted') != -1)
> +	   return;
> +    document.getElementById("searchBox").value= 'quentin';
Might be better to stick with double-quote than single-quote, for consistency.

> +    document.getElementById("searchForm").submit();
> +};
> +</script>
> +</HEAD>
> +<BODY>
> +
> +<p>This page tests that a page with a search popup does not crash, as
reported in <a href='https://bugs.webkit.org/show_bug.cgi?id=37141'>this
bug</a>. Below is a search input that the test automatically fills than submit.
Pass if this does not crash.</p><br><br>
Typo: than => then