[webkit-reviews] review granted: [Bug 37164] Poor rendering on lala.com with frame flattening : [Attachment 52744] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 37164: Poor rendering on lala.com with frame flattening
https://bugs.webkit.org/show_bug.cgi?id=37164

Attachment 52744: Patch
https://bugs.webkit.org/attachment.cgi?id=52744&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    // do not flatten offscreen inner frames during frame flattening.

This comment needs to go closer to the logic, probably on the last paragraph.

> +    IntRect rect(IntPoint(0, 0), view->contentsSize());
> +    return rect.intersects(absoluteBoundingBoxRect());

I don't think we need a local variable here. I would write it in one line like
this:

    return absoluteBoundingBoxRect().intersects(IntPoint(),
view->contentsSize());

I guess I'll say r=me as is, but I'm not going to set commit-queue+ yet. You
can change it back to + if you want to land this patch as-is.