[webkit-reviews] review requested: [Bug 37112] aria-liveregion-notifications.html fails on leopard release bot : [Attachment 52742] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 7 09:25:48 PDT 2010


chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 37112: aria-liveregion-notifications.html fails on leopard release bot
https://bugs.webkit.org/show_bug.cgi?id=37112

Attachment 52742: patch
https://bugs.webkit.org/attachment.cgi?id=52742&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
I've redone the mechanism for how accessibility notifications are handled.

Now, DRT will set a flag that tells WebCore it should send out a
NSNotification. Now any DRT object can just listen for that notification when
they want to and stop when they dont.
The previous method stored a static function pointer in WebCore that it called
back, which I suspect was causing some race condition flakiness

I also required that tests using this mechanism inform DRT when they are done
listening, which allows for easier cleanup.

I am also adding four tests which are basically the
aria-liveregion-notifications.html broken into its components. In my testing,
having these four tests
run really stressed the system and brought out bugs, so I'd like to leave them
there to see if they help bring out bugs on these other platforms


More information about the webkit-reviews mailing list