[webkit-reviews] review requested: [Bug 29431] [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical, Qt::ScrollBarAlwaysOff) has no effect. : [Attachment 52736] patch_1 - v3 - addressed discussion with dhyatt on IRC

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 29431: [Qt] REGRESSION:(r50665)
QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no
effect.
https://bugs.webkit.org/show_bug.cgi?id=29431

Attachment 52736: patch_1 - v3 - addressed discussion with dhyatt on IRC
https://bugs.webkit.org/attachment.cgi?id=52736&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
As accorded on IRC, this patch:

* adds additional lock parameters to setScrollbarModes,
setVerticalScrollbarMode and setHorizontalScrollbarMode of ScrollView;
* make the latter two just call the former passing the appropriated parameters,
as originally;
* adds two optional lock parameters to Frame::createView, for locking
horizontal and vertical scrollbars, respectively.
* adds a layout test and a qt API unit test
* make the adjusts needed in FrameLoaderClientQt, to use the new createView
parameters.