[webkit-reviews] review canceled: [Bug 37194] Prevent wrong use of PrintContext : [Attachment 52714] Patch v1

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 37194: Prevent wrong use of PrintContext
https://bugs.webkit.org/show_bug.cgi?id=37194

Attachment 52714: Patch v1
https://bugs.webkit.org/attachment.cgi?id=52714&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
>  PrintContext::~PrintContext()
>  {
> +    if (m_isPrinting)
> +	   end();
>      m_pageRects.clear();
>  }

Or, we may want to add ASSERT(!m_isPrinting) here. I personally like this kind
of automatic release, but I'm not sure if this is suitable for this case. If a
user of PrintContext relies on this, her/his code may have begin() without
end(), which might look weird a bit. Hmm... I changed my mind while I'm writing
this comment. I'll revise the patch.