[webkit-reviews] review granted: [Bug 37160] [V8] Throw exception in SerializedScriptValue on input errors : [Attachment 52650] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 7 00:08:01 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has granted Vitaly Repeshko
<vitalyr at chromium.org>'s request for review:
Bug 37160: [V8] Throw exception in SerializedScriptValue on input errors
https://bugs.webkit.org/show_bug.cgi?id=37160

Attachment 52650: patch v1
https://bugs.webkit.org/attachment.cgi?id=52650&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
> -    explicit SerializedScriptValue(v8::Handle<v8::Value>);
> +    SerializedScriptValue(v8::Handle<v8::Value>, bool& didThrow);
> 
I don't like the idea of out parameter in the constructor but since it's
private I think that is ok.


More information about the webkit-reviews mailing list