[webkit-reviews] review granted: [Bug 36911] Add webkit-patch command to crawl buildbot history and find when tests started to fail : [Attachment 52704] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 6 23:37:46 PDT 2010


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 36911: Add webkit-patch command to crawl buildbot history and find when
tests started to fail
https://bugs.webkit.org/show_bug.cgi?id=36911

Attachment 52704: Patch
https://bugs.webkit.org/attachment.cgi?id=52704&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok.  Let's take this as a starting point.  As you noted in the other bug,
there's a lot of overlap with the algorithm the sheriff uses to track recent
regressions.  This code looks like it understands more cases (e.g., >= 20
failures).  We should find a way to unify and abstract out the different
pieces,but I don't want to hold this patch hostage any longer.


More information about the webkit-reviews mailing list