[webkit-reviews] review denied: [Bug 36899] Make DumpRenderTree parallelizable : [Attachment 52261] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 6 20:57:50 PDT 2010
Eric Seidel <eric at webkit.org> has denied Csaba Osztrogonac <ossy at webkit.org>'s
request for review:
Bug 36899: Make DumpRenderTree parallelizable
https://bugs.webkit.org/show_bug.cgi?id=36899
Attachment 52261: proposed patch
https://bugs.webkit.org/attachment.cgi?id=52261&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't believe that this is sufficient to make Mac work, but it is probably
better than what we have now.
Also, why call getenv so many times? Why not just once and cache the result in
a local variable?
Do we know if this makes the IconDatbase crashers on the Qt bot go away?
More information about the webkit-reviews
mailing list