[webkit-reviews] review granted: [Bug 37164] Poor rendering on lala.com with frame flattening : [Attachment 52657] This patch addresses the problem.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Greg Bolsinga <bolsinga at apple.com>'s
request for review:
Bug 37164: Poor rendering on lala.com with frame flattening
https://bugs.webkit.org/show_bug.cgi?id=37164

Attachment 52657: This patch addresses the problem.
https://bugs.webkit.org/attachment.cgi?id=52657&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (isPositioned() && containingBlock() == view() && ((x() + width() <=
0) || (y() + height() <= 0)))
> +	   return false;

"x() + width()" is "frameRect().right()" and I think we should use that
instead.

"y() + height()" is "frameRect().bottom()" and I think we should use that
instead

A much better way to do this would be to call frameRect().intersects(xxx),
where xxx is the viewport. Checking specifically for right and bottom that are
off the left and top edge is too specific and will miss other valuable cases.

r=me despite these concerns