[webkit-reviews] review granted: [Bug 37026] [Qt] WebKit does not build on Windows with --3d-canvas : [Attachment 52576] Windows compilation fix

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has granted Jarkko Sakkinen
<jarkko.j.sakkinen at gmail.com>'s request for review:
Bug 37026: [Qt] WebKit does not build on Windows with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=37026

Attachment 52576: Windows compilation fix
https://bugs.webkit.org/attachment.cgi?id=52576&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
>  // FIXME: Find a better way to avoid the name confliction for NO_ERROR.
> -#if ((PLATFORM(CHROMIUM) && OS(WINDOWS)) || PLATFORM(WIN))
> +#if ((PLATFORM(CHROMIUM) && OS(WINDOWS)) || PLATFORM(WIN) || (PLATFORM(QT)
&& OS(WINDOWS)))
>  #undef NO_ERROR
>  #endif

It seems to me that this test should be simply OS(WINDOWS), instead of listing
all the ports one-by-one that builds on Windows.

This looks good to me as a build fix, r+.