[webkit-reviews] review requested: [Bug 37136] [Qt] Fix trunk (non-standalone) builds for Symbian : [Attachment 52607] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 22:46:16 PDT 2010


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 37136: [Qt] Fix trunk (non-standalone) builds for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37136

Attachment 52607: proposed patch
https://bugs.webkit.org/attachment.cgi?id=52607&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Test for source files before building instead of relying on standalone_package
config test.

This not only fixes the bug, but I think it also makes the build file more
readable and potentially even allows to patch a package build with some goodies
(e.g. Dumprendertree) from trunk sources.

I was not sure of the package build includes QtLauncher so I moved that build
target to be optional (only build it if exists) as well.


More information about the webkit-reviews mailing list